Re: [PATCH 1/2] seccomp: fix up grammar in comment

From: Kees Cook
Date: Tue Apr 23 2019 - 18:11:20 EST


On Wed, Mar 6, 2019 at 12:14 PM Tycho Andersen <tycho@xxxxxxxx> wrote:
>
> This sentence is kind of a train wreck anyway, but at least dropping the
> extra pronoun helps somewhat.
>
> Signed-off-by: Tycho Andersen <tycho@xxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

James, this can go in for v5.2 -- no rush.

-Kees

> ---
> kernel/seccomp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index e815781ed751..d0d355ded2f4 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -329,7 +329,7 @@ static int is_ancestor(struct seccomp_filter *parent,
> * Expects sighand and cred_guard_mutex locks to be held.
> *
> * Returns 0 on success, -ve on error, or the pid of a thread which was
> - * either not in the correct seccomp mode or it did not have an ancestral
> + * either not in the correct seccomp mode or did not have an ancestral
> * seccomp filter.
> */
> static inline pid_t seccomp_can_sync_threads(void)
> --
> 2.19.1
>


--
Kees Cook