Re: [PATCH RESEND v5 0/5] namei: vfs flags to restrict path resolution

From: Christian Brauner
Date: Tue Apr 23 2019 - 16:24:11 EST


On Tue, Apr 23, 2019 at 01:13:52PM -0700, Kees Cook wrote:
> On Mon, Mar 25, 2019 at 6:05 AM Aleksa Sarai <cyphar@xxxxxxxxxx> wrote:
> >
> > On 2019-03-21, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> > > On Wed, Mar 20, 2019 at 7:38 AM Aleksa Sarai <cyphar@xxxxxxxxxx> wrote:
> > > > Now that the holiday break is over, it's time to re-send this patch
> > > > series (with a few additions, due to new information we got from
> > > > CVE-2019-5736 -- which this patchset mostly protected against but had
> > > > some holes with regards to #!-style scripts).
> > >
> > > I generally like this, but, as Linus pointed out, it will be
> > > unfortunate if application authors see this as just another
> > > non-portable weird Linux API and don't use it. Would it be worthwhile
> > > to put some thought into making it an API that other OSes might be
> > > willing to implement? As it stands, the openat(2) flags are getting
> > > rather crazy in this patch set.
>
> I think many of the issues are specific to Linux (and Linux containers
> especially), so I'm not sure this should get blocked because we want
> something more portable.
>
> This series provides solutions to so many different race and confusion
> issues, I'd really like to see it land. What's the next step here? Is
> this planned to go directly to Linus for v5.2, or is it going to live
> in -mm for a while? I'd really like to see this moving forward.

Yeah, it would be good to move this forward. But since this is pretty
much core-vfs we really need Al to take a look at this.

Christian