Re: [Xen-devel] [PATCH v2 1/2] xen/pvh: set xen_domain_type to HVM in xen_pvh_init

From: Roger Pau MonnÃ
Date: Tue Apr 23 2019 - 10:57:43 EST


On Tue, Apr 23, 2019 at 09:37:51AM -0400, Boris Ostrovsky wrote:
> On 4/23/19 9:04 AM, Roger Pau Monne wrote:
> > Or else xen_domain() returns false despite xen_pvh being set.
>
> Is this new xen_domain() invocation somewhere in EFI initialization that
> you add in the second patch?

Yes, there's a xen_initial_domain() call in xen_efi_probe() which
would return false without this fix.

> Asking because I am trying to figure out whether this needs to go to
> stable tree.

I'm not aware of this being an issue without the EFI code that I add
in patch 2, xen_domain_type would get set slightly later in the boot
process.

I guess both patches should be backported to 4.19 since that's the
only LTS release that has PVH dom0 support IIRC, and it would be good
to get this fixed.

Thanks, Roger.