Re: [PATCH] reiserfs: Force type conversion in xattr_hash

From: Bharath Vedartham
Date: Tue Apr 23 2019 - 10:55:37 EST


On Mon, Apr 22, 2019 at 12:27:05PM -0700, Andrew Morton wrote:
> On Sun, 21 Apr 2019 18:02:35 +0100 Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> > IOW, what sparse has caught here is a genuine endianness bug; images
> > created on little-endian host and mounted on big-endian (or vice
> > versa) will see csum mismatches when trying to fetch xattrs.
>
> OK, thanks. I'll drop the patch - we shouldn't hide that reminder of a
> bug.
>
> Perhaps someone could prepare a patch which adds a comment explaining
> these issues, so someone else doesn't try to "fix" the sparse warning.
>

Hi Andrew,

I will send a patch CCing Al to add a comment explaining these issues.

Thanks
Bharath