Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: fix interrupt type

[Jiada Wang]

Hi Eugeniu

On 2019/04/23 22:07, Eugeniu Rosca wrote:
> Hi Jiada,
>
> On Tue, Apr 23, 2019 at 03:12:17PM +0900, Jiada Wang wrote:
> > Currently IRQF_SHARED type interrupt line is allocated, but it
> > is not appropriate, as the interrupt line isn't shared between
> > different devices, instead IRQF_ONESHOT is the proper type.
> >
> > By changing interrupt type to IRQF_ONESHOT, now irq handler is
> > no longer needed, as clear of interrupt status can be done in
> > threaded interrupt context.
> >
> > Because IRQF_ONESHOT type interrupt line is kept disabled until
> > the threaded handler has been run, so there is no need to protect
> > read/write of REG_GEN3_IRQSTR with lock.
> >
> > Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx>
> > ---
> >   drivers/thermal/rcar_gen3_thermal.c | 40 ++++++++---------------------
> >   1 file changed, 10 insertions(+), 30 deletions(-)
>
> [..]
>
> I might be doing something wrong, but I couldn't apply this patch on top
Oops, I think I used wrong code base,
I will send out v3 patch-set soon

sorry about that

Thanks,
Jiada
> of v5.1-rc6-4-g7142eaa58b49. All below commands failed (git v2.21.0):
>   - git am this.patch
>   - git apply this.patch
>   - patch -p1 < this.patch