Re: [PATCH AUTOSEL 5.0 70/98] tty: fix NULL pointer issue when tty_port ops is not set

From: Greg Kroah-Hartman
Date: Mon Apr 22 2019 - 16:40:09 EST


On Mon, Apr 22, 2019 at 03:41:37PM -0400, Sasha Levin wrote:
> From: Fabien Dessenne <fabien.dessenne@xxxxxx>
>
> [ Upstream commit f4e68d58cf2b20a581759bbc7228052534652673 ]
>
> Unlike 'client_ops' which is initialized to 'default_client_ops', the
> port operations 'ops' may be left to NULL.
> Check the 'ops' value before checking the 'ops->x' value.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@xxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin (Microsoft) <sashal@xxxxxxxxxx>
> ---
> drivers/tty/tty_port.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

Nope, I have a revert for this in my tree for 5.2-rc1, no need for this
in any stable tree, it doesn't do anything :)

Please drop it from all branches, thanks.

greg k-h