Re: [PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

From: Wolfram Sang
Date: Mon Apr 22 2019 - 03:20:45 EST


On Sun, Apr 21, 2019 at 06:15:21PM +0000, Peter Rosin wrote:
> On 2019-01-04 19:06, Wolfram Sang wrote:
> >
> >> Instead of leaving these open-coded and prone to type mistakes, we can
> >> now use the new struct_size() helper:
> >
> > I am okay with this patch in general. However, I think the name of the
> > helper 'struct_size' is a bit unfortunate. I really wondered on the
> > first read why it needs 3 arguments to find out a struct size. I only
> > understood on the second read. I think 'trailing_array_struct_size'
> > would be way more clearer what it does.
>
> I read that as an Acked-by... :-)

For this patch, yes. Thanks!

Attachment: signature.asc
Description: PGP signature