Re: [PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver support

From: Shawn Guo
Date: Sun Apr 21 2019 - 03:40:30 EST


On Thu, Apr 11, 2019 at 06:49:12AM +0000, Anson Huang wrote:
> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> inside, the system controller is in charge of controlling power,
> clock and fuse etc..
>
> This patch adds i.MX system controller soc driver support,
> Linux kernel has to communicate with system controller via MU
> (message unit) IPC to get soc revision, uid etc..
>
> With this patch, soc info can be read from sysfs:
>
> i.mx8qxp-mek# cat /sys/devices/soc0/family
> Freescale i.MX
>
> i.mx8qxp-mek# cat /sys/devices/soc0/soc_id
> i.MX8QXP
>
> i.mx8qxp-mek# cat /sys/devices/soc0/machine
> Freescale i.MX8QXP MEK
>
> i.mx8qxp-mek# cat /sys/devices/soc0/revision
> 1.1
>
> i.mx8qxp-mek# cat /sys/devices/soc0/soc_uid
> 7B64280B57AC1898
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> ---
> drivers/soc/imx/Kconfig | 7 ++
> drivers/soc/imx/Makefile | 1 +
> drivers/soc/imx/soc-imx-sc.c | 220 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 228 insertions(+)
> create mode 100644 drivers/soc/imx/soc-imx-sc.c

Rather than creating a new driver, please take a look at Abel's generic
i.MX8 SoC driver, and see if it can be extended to cover i.MX8QXP.

Shawn