Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary

[Masahiro Yamada]

Hi Joe,

Can you detect redundant Cc: by checkpatch?

Please see below in details.
Thanks.


On Fri, Apr 19, 2019 at 8:07 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 17 Apr 2019 15:37:49 +0900 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> > > It's pretty benign: Doug will still only get a single email.
> > >
> > >
> > > checkpatch checks for duplicates cc's but I think it assumes that
> > > things like
> > >
> > > Reported-by: fred
> > > Tested-by: fred
> > >
> > > were intentional.
> > >
> > > It would perhaps be better for checkpatch to special-case the "Cc:
> > > fred" tag and report a duplicated Cc: if fred was also mentioned in any
> > > other tag.
> >
> > Sorry, I do not understand what you mean.
> >
> >
> > Douglas did not add any Cc: tag at all
> > in his original patch:
> > https://lore.kernel.org/patchwork/patch/1053953/
> >
> >
> > It's you who added the Cc: tags
> > (and I am guessing you did it by scripting.)
> >
> > Why is this topic related to checkpatch?
>
> Because I regularly check all patches with checkpatch but checkpatch
> failed to detect that I had
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ...
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> and I believe that checkpatch could and should have warned about this
> situation.
>


-- 
Best Regards
Masahiro Yamada