Re: [PATCH v2 3/5] signal: use fdget() since we don't allow O_PATH

From: Christian Brauner
Date: Thu Apr 18 2019 - 11:53:33 EST


On Thu, Apr 18, 2019 at 08:37:28AM -0700, Linus Torvalds wrote:
> On Thu, Apr 18, 2019 at 3:19 AM Christian Brauner <christian@xxxxxxxxxx> wrote:
> >
> > It's just semantically correct to use fdget()
> > and return an error right from there instead of taking a reference and
> > returning an error later.
>
> I've applied this one directly, because it ends up affecting the
> existing code, and I'd rather just have the initial release of
> pidfd_send_signal() right.

Perfect! Thank you!

>
> The other patches I consider to be "future release" material.

Yes, indeed. Jann and I are targeting the 5.2 merge window if that's ok.

Christian