Re: [PATCH] crypto: ccp: Do not free psp_master when PLATFORM_INIT fails

From: Herbert Xu
Date: Thu Apr 18 2019 - 11:08:13 EST


On Mon, Apr 08, 2019 at 08:42:55PM +0000, Singh, Brijesh wrote:
> Currently, we free the psp_master if the PLATFORM_INIT fails during the
> SEV FW probe. If psp_master is freed then driver does not invoke the PSP
> FW. As per SEV FW spec, there are several commands (PLATFORM_RESET,
> PLATFORM_STATUS, GET_ID etc) which can be executed in the UNINIT state
> We should not free the psp_master when PLATFORM_INIT fails.
>
> Fixes: 200664d5237f ("crypto: ccp: Add SEV support")
> Cc: Tom Lendacky <thomas.lendacky@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: Gary Hook <gary.hook@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 4.19.y
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> ---
> drivers/crypto/ccp/psp-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt