Re: [PATCH v2 4/5] signal: support CLONE_PIDFD with pidfd_send_signal

From: Oleg Nesterov
Date: Thu Apr 18 2019 - 10:26:07 EST


On 04/18, Christian Brauner wrote:
>
> +static struct pid *pidfd_to_pid(const struct file *file)
> +{
> + if (file->f_op == &pidfd_fops)
> + return file->private_data;
> +
> + return tgid_pidfd_to_pid(file);
> +}

the patch looks obviously fine to me, but I have an absolutely off-topic
question... why tgid_pidfd_to_pid() has to check d_is_dir() ?

Oleg.