Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure

From: Stefan Wahren
Date: Thu Apr 18 2019 - 08:34:59 EST


On 18.04.19 12:29, Nicholas Mc Guire wrote:
> The kzalloc here was being used without checking the return - if the
> kzalloc fails return VCHIQ_ERROR. The call-site of
> vchiq_platform_init_state() vchiq_init_state() was not responding
> to an allocation failure so checks for != VCHIQ_SUCCESS
> and pass VCHIQ_ERROR up to vchiq_platform_init() which then
> will fail with -EINVAL.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>

Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>