Re: [PATCH v3] usb/hcd: Send a uevent signaling that the host controller had died

From: Alan Stern
Date: Wed Apr 17 2019 - 15:14:18 EST


On Wed, 17 Apr 2019, Raul E Rangel wrote:

> +/* Workqueue routine for when the root-hub has died. */
> +static void hcd_died_work(struct work_struct *work)
> +{
> + struct usb_hcd *hcd = container_of(work, struct usb_hcd, died_work);
> + char *env[] = {
> + "ERROR=DEAD",
> + NULL
> + };

This can now be

static const char *env[] = ...

right? There's no need for the array to be reinitialized every time
the routine runs.

Alan Stern