Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller

From: Sven Van Asbroeck
Date: Wed Apr 17 2019 - 10:17:26 EST


On Wed, Apr 17, 2019 at 4:41 AM Enrico Weigelt, metux IT consult
<lkml@xxxxxxxxx> wrote:
> hmm, I think the main question here is clean separation between
> subsystems - devices that span multiple subsystems, IMHO, fall
> into the category "mfd".
>

Generally I agree wholeheartedly, but as we discussed,
it might not be worth the trouble in this case.

> separate drivers probably don't make much sense here, but maybe
> a CONFIG_ flag for disabling this functionality ?

Yes, I can add that for sure !

>
> hmm, wouldn't the input subsystem be more appropriate for that ?
>

The input subsystem is concerned with input from humans?
But in this case, it's really a power output from an external card
on a PCB assembly. Regulator seemed the kernel abstraction
closest to what this actually represents.

I'm honestly not fully satisfied by the use of the regulator
abstraction here. If you know of a different abstraction
which seems better, I'll definitely consider it.