Re: [PATCH v2] mtd: rawnand: ams-delta: Drop board specific partition info

From: Miquel Raynal
Date: Wed Apr 17 2019 - 05:40:23 EST


Hi Janusz,

Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx> wrote on Sun, 24 Mar 2019
23:33:44 +0100:

> After recent modifications, only a hardcoded partition info makes
> the driver device specific. Other than that, the driver uses GPIO
> exclusively and can be used on any hardware.
>
> Drop the partition info and use MTD partition parser with default list
> of parser names instead. For the OF parser to work correctly, pass
> device of_node to mtd.
>
> Amstrad Delta users should append the following partition info to their
> kernel command line, possibly by embedding it in CONFIG_CMDLINE:
>
> mtdparts=ams-delta-nand:3584k(Kernel),256k(u-boot),256k(u-boot_params),\
> 256k(Amstrad_LDR),27m(File_system),768k(PBL_reserved).
>
> For their convenience, CONFIG_MTD_CMDLINE_PARTS symbol is selected
> automatically from that board Kconfig if this NAND driver is also
> selected.
>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> ---

FYI I am okay with the change but I am waiting for acks before applying
it.

Thanks,
MiquÃl