Re: [PATCH] binfmt_elf: Move brk out of mmap when doing direct loader exec

From: Andrew Morton
Date: Tue Apr 16 2019 - 19:38:01 EST


On Tue, 16 Apr 2019 18:14:00 -0500 Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> On Tue, Apr 16, 2019 at 6:04 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > >
> > > Reported-by: Ali Saidi <alisaidi@xxxxxxxxxx>
> > > Link: https://lkml.kernel.org/r/CAGXu5jJ5sj3emOT2QPxQkNQk0qbU6zEfu9=Omfhx_p0nCKPSjA@xxxxxxxxxxxxxx
> > > Fixes: eab09532d400 ("binfmt_elf: use ELF_ET_DYN_BASE only for PIE")
> > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >
> > No cc:stable?
>
> Probably it should be, yes. I think I'm just shy about that when
> poking ELF mappings. :)

Well, the -stable bots will backport anything that might look slightly
like a fix anyway.

I'll add cc:stable and shall hold it out until 5.2-rc1, so it should
get a bit of a spin before being backported.