Re: [PATCH v4 4/9] driver core: Let dev_of_node() accept a NULL dev

From: Greg Kroah-Hartman
Date: Tue Apr 16 2019 - 10:20:03 EST


On Fri, Apr 12, 2019 at 11:31:45AM -0700, Stephen Boyd wrote:
> We'd like to chain this in places where the 'dev' argument might be
> NULL. Let this function take a NULL 'dev' so this can work.
>
> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Cc: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> ---
>
> Please ack/review so I can take this through clk tree.
>
> include/linux/device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index b425a7ee04ce..0370dd0b3ae7 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1231,7 +1231,7 @@ static inline void device_lock_assert(struct device *dev)
>
> static inline struct device_node *dev_of_node(struct device *dev)
> {
> - if (!IS_ENABLED(CONFIG_OF))
> + if (!IS_ENABLED(CONFIG_OF) || !dev)
> return NULL;
> return dev->of_node;
> }

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>