Re: [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig

From: Gaurav Kohli
Date: Tue Apr 16 2019 - 07:16:02 EST


Hi ,

I have reviewed and tested for both enabled and disabled and working as expected.

Please feel free to add:

Reviewed-by: Gaurav Kohli <gkohli@xxxxxxxxxxxxxx>
Tested-by: Gaurav Kohli <gkohli@xxxxxxxxxxxxxx>

Regards
Gaurav
On 4/16/2019 4:31 PM, Mika Westerberg wrote:
On Tue, Apr 16, 2019 at 10:59:24AM +0100, Srinivas Kandagatla wrote:
Many nvmem providers are not very keen on having default sysfs
nvmem entry, as most of the usecases for them are inside kernel
itself. And in some cases read/writes to some areas in nvmem are
restricted and trapped at secure monitor level, so accessing them
from userspace would result in board reboots.

This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry
an optional one. This provision will give more flexibility to users.
This patch also moves existing sysfs code to a new file so that its
not compiled in when its not really required.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>


--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.