Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up

From: Martin K. Petersen
Date: Mon Apr 15 2019 - 19:33:47 EST



John,

> This patchset introduces some minor improvements and tidy-up, including:
> - fix PHY info in sysfs for PHY events
> - min pathway rate programming improvement
> - some other tidy-up and neatening

Applied to 5.2/scsi-queue, thanks!

One thing that always bugged me is the ambiguous "ex" prefix for many
libsas log messages. And in a way, your patch #3 makes things worse by
replacing the more descriptive "Expander" with "ex". It does make things
more consistent, though.

I'd really like to see all the libsas messages be cleaned up with a
sensible prefix and a consistent format where possible.

--
Martin K. Petersen Oracle Linux Engineering