Re: [PATCH 3/3] RISC-V: Access CSRs using CSR numbers

From: Anup Patel
Date: Sat Apr 13 2019 - 04:16:24 EST


On Sat, Apr 13, 2019 at 1:25 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Sat, Apr 13, 2019 at 07:39:44AM +0000, Anup Patel wrote:
> > We should prefer accessing CSRs using their CSR numbers because:
> > 1. It compiles fine with older toolchains.
> > 2. We can use latest CSR names in #define macro names of CSR numbers
> > as-per RISC-V spec.
> > 3. We can access newly added CSRs even if toolchain does not recognize
> > newly addes CSRs by name.
>
> This looks mostly fine, but also please remove all the comments
> regarding using sptbr instead of satp now that they are not true
> anymore.

Sure, will do.

Regards,
Anup