Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

[Eugeniy Paltsev]

Hi Jose,

On Mon, 2019-04-08 at 11:23 +0000, Jose Abreu wrote:
> From: Vitor Soares <vitor.soares@xxxxxxxxxxxx>
> Date: Mon, Apr 08, 2019 at 11:31:23
> 
> >  static const struct reset_control_ops axs10x_reset_ops = {
> > -	.reset	= axs10x_reset_reset,
> 
> Eugeniy, Alexey,
> 
> I think the implementation of this callback is wrong: you should
> readl_poll_timeout_atomic() until the reset bit is not cleared.

I don't remember if this register is read/write or write-only. I'll check it.
Thanks for report.

> 
> Thanks,
> Jose Miguel Abreu
-- 
 Eugeniy Paltsev