Re: [RFC patch 40/41] stacktrace: Remove obsolete functions

From: Peter Zijlstra
Date: Thu Apr 11 2019 - 05:13:38 EST


On Wed, Apr 10, 2019 at 10:33:20PM -0500, Josh Poimboeuf wrote:
> On Wed, Apr 10, 2019 at 12:28:34PM +0200, Thomas Gleixner wrote:

> > +struct stack_trace {
> > + unsigned int nr_entries, max_entries;
> > + unsigned long *entries;
> > + int skip; /* input argument: How many entries to skip */
> > +};
>
> I was a bit surprised to see struct stack_trace still standing at the
> end of the patch set, but I guess 41 patches is enough :-) Do we want
> to eventually remove the struct altogether?
>
> I was also hoping to see the fragile "skipnr" go away in favor of
> something less dependent on compiler optimizations, but I'm not sure how
> feasible that would be.

It will die, but that only takes another nr_arch+1 patches.