Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

[Tony Lindgren]

Hi,

* Stefan Agner <stefan@xxxxxxxx> [190408 20:59]:
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -41,11 +41,6 @@ obj-$(CONFIG_SOC_OMAP5)			+= $(omap-4-5-common) $(smp-y) sleep44xx.o
>  obj-$(CONFIG_SOC_AM43XX)		+= $(omap-4-5-common)
>  obj-$(CONFIG_SOC_DRA7XX)		+= $(omap-4-5-common) $(smp-y) sleep44xx.o
>  
> -plus_sec := $(call as-instr,.arch_extension sec,+sec)
> -AFLAGS_omap-headsmp.o			:=-Wa,-march=armv7-a$(plus_sec)
> -AFLAGS_omap-smc.o			:=-Wa,-march=armv7-a$(plus_sec)
> -AFLAGS_sleep44xx.o			:=-Wa,-march=armv7-a$(plus_sec)
> -
>  # Functions loaded to SRAM
>  obj-$(CONFIG_SOC_OMAP2420)		+= sram242x.o
>  obj-$(CONFIG_SOC_OMAP2430)		+= sram243x.o
> @@ -95,9 +90,6 @@ obj-$(CONFIG_POWER_AVS_OMAP)		+= sr_device.o
>  obj-$(CONFIG_POWER_AVS_OMAP_CLASS3)    += smartreflex-class3.o
>  
>  AFLAGS_sleep24xx.o			:=-Wa,-march=armv6
> -AFLAGS_sleep34xx.o			:=-Wa,-march=armv7-a$(plus_sec)
> -AFLAGS_sleep33xx.o			:=-Wa,-march=armv7-a$(plus_sec)
> -AFLAGS_sleep43xx.o			:=-Wa,-march=armv7-a$(plus_sec)

I think we should also change the AFLAGS_sleep24xx.o above the
same way but with armv6 flags. This can be build tested with
omap2plus_defconfig.

Regards,

Tony