Re: [PATCH] afs: Mark expected switch fall-throughs

[David Howells]

Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:

Please fix the compiler so that you can annotate a switch-statement to say
that every case must fall through (except, perhaps, the last).

>  		/* extract the FID array and its count in two steps */
> +		/* fall through */
>  	case 1:

Capitialise "Fall" for consistency, please, and can you put the fall-through
marker *before* the comment introducing the case please?  It belongs to the
preceding section.

>  		/* extract the callback array and its count in two steps */
> +		/* fall through */
>  	case 3:

Ditto.

>  		/* extract the FID array and its count in two steps */
> +		/* Fall through */

Ditto on putting the fall-through before the introductory comment.

(And more dittos).

> -		/* Extract fsEndpoints[] entries */
> +		/* Fall through - and extract fsEndpoints[] entries */

And here you're doing something different yet again, though you could drop
either the "-" or the "and".

David