Re: [RFC PATCH v2 2/3] arch/x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for Acrn upcall vector

[Zhao, Yakui]

On 2019å04æ06æ 03:07, Thomas Gleixner wrote:
> On Tue, 26 Mar 2019, Zhao Yakui wrote:
> > diff --git a/arch/x86/include/asm/hardirq.h b/arch/x86/include/asm/hardirq.h
> > index d9069bb..a8f4d08 100644
> > --- a/arch/x86/include/asm/hardirq.h
> > +++ b/arch/x86/include/asm/hardirq.h
> > @@ -37,7 +37,8 @@ typedef struct {
> >   #ifdef CONFIG_X86_MCE_AMD
> >   	unsigned int irq_deferred_error_count;
> >   #endif
> > -#if IS_ENABLED(CONFIG_HYPERV) || defined(CONFIG_XEN)
> > +#if IS_ENABLED(CONFIG_HYPERV) || defined(CONFIG_XEN) ||\
> > +		defined(CONFIG_ACRN_GUEST)
>
> ..
>
> > @@ -134,7 +134,8 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> >   		seq_printf(p, "%10u ", per_cpu(mce_poll_count, j));
> >   	seq_puts(p, "  Machine check polls\n");
> >   #endif
> > -#if IS_ENABLED(CONFIG_HYPERV) || defined(CONFIG_XEN)
> > +#if IS_ENABLED(CONFIG_HYPERV) || defined(CONFIG_XEN) ||\
> > +		defined(CONFIG_ACRN_GUEST)
> >   	if (test_bit(HYPERVISOR_CALLBACK_VECTOR, system_vectors)) {
> >   		seq_printf(p, "%*s: ", prec, "HYP");
> >   		for_each_online_cpu(j)
>
> This starts to become unreadable. Please create a new config symbol:
>
>       config X86_HV_CALLBACK_VECTOR
>       	def_bool
>
> and select if from HYPERV, XEN and your new thing. That wants to be a
> separate preparatory patch at the beginning of the series please.

Thanks for the suggestion.
Sure. One new config will be added in next version.


> Thanks,
>
> 	tglx