Re: [PATCH 2/6] iio: imx7d_adc: Replace pr_err with dev_err

From: Jonathan Cameron
Date: Sun Apr 07 2019 - 07:04:02 EST


On Wed, 3 Apr 2019 00:03:21 -0700
Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:

> Replace combination of pr_err()/dev_name() with an equivalent call for
> dev_err().
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Hartmut Knaack <knaack.h@xxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
> Cc: Chris Healy <cphealy@xxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
Applied, thanks,

Jonathan

> ---
> drivers/iio/adc/imx7d_adc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
> index 3bbd657409d5..72cfe9834bcb 100644
> --- a/drivers/iio/adc/imx7d_adc.c
> +++ b/drivers/iio/adc/imx7d_adc.c
> @@ -388,8 +388,9 @@ static irqreturn_t imx7d_adc_isr(int irq, void *dev_id)
> * timeout flags.
> */
> if (status & IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT) {
> - pr_err("%s: ADC got conversion time out interrupt: 0x%08x\n",
> - dev_name(info->dev), status);
> + dev_err(info->dev,
> + "ADC got conversion time out interrupt: 0x%08x\n",
> + status);
> status &= ~IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT;
> writel(status, info->regs + IMX7D_REG_ADC_INT_STATUS);
> }