Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

From: Dan Carpenter
Date: Thu Apr 04 2019 - 15:14:46 EST


On Thu, Apr 04, 2019 at 12:10:44PM -0700, Andrew Morton wrote:
> On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> > The strndup_user() function returns error pointers on error, and then
> > in the error handling we pass the error pointers to kfree(). It will
> > cause an Oops.
> >
>
> Looks good to me.
>
> I guess we should fix this too?
>

I didn't notice that. Thanks!

regards,
dan carpenter