RE: [PATCH] mm/gup.c: fix the wrong comments

From: Weiny, Ira
Date: Thu Apr 04 2019 - 12:54:05 EST


> > On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@xxxxxxxxxxx> wrote:
> >
> >
> > + * This function is different from the get_user_pages_unlocked():
> > + * The @pages may has different page order with the result
> > + * got by get_user_pages_unlocked().
> > + *
>
> I suggest a slight rewrite of the comment, something like:
>
> * Note this routine may fill the pages array with entries in a
> * different order than get_user_pages_unlocked(), which may cause
> * issues for callers expecting the routines to be equivalent.

This is good too. :-D

Ira