Re: [PATCH] gpio: omap: avoid clang warning

From: Linus Walleij
Date: Wed Apr 03 2019 - 12:33:21 EST


On Thu, Mar 7, 2019 at 5:33 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> clang warns about a tentative array definition in the gpio-omap driver:
>
> drivers/gpio/gpio-omap.c:1282:34: error: tentative array definition assumed to have one element [-Werror]
> static const struct of_device_id omap_gpio_match[];
>
> It's best to just reorder the entire file to avoid forward declarations,
> which lets us use the regular declaration. To do this, the unnecessary
> CONFIG_OF check must also be removed.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Patch applied.

Yours,
Linus Walleij