Re: [PATCH net-next 04/12] net: hns3: return 0 and print warning when hit duplicate MAC

[tanhuazhong]

On 2019/4/3 17:15, Sergei Shtylyov wrote:
> On 03.04.2019 6:07, Huazhong Tan wrote:
>
> > From: Peng Li <lipeng321@xxxxxxxxxx>
> >
> > When set 2 same MAC to different function of one port, IMP
> > will return error as the later one may modify the origin one.
> > This will cause bond fail for 2 VFs of one port.
> >
> > Driver just print warning and return 0 with this patch, so
> > if set same MAC address, it will return 0 but do not really
> > configure to HW.
>
>  ÂÂ "To" not needed here.

ok, thanks.

> > Signed-off-by: Peng Li <lipeng321@xxxxxxxxxx>
> > Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>
> > ---
> > Â drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +++++--
> > Â 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c 
> > b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > index e742a05..d45789e 100644
> > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > @@ -5962,8 +5962,11 @@ int hclge_add_uc_addr_common(struct hclge_vport 
> > *vport,
> > ÂÂÂÂÂ }
> > ÂÂÂÂÂ /* check if we just hit the duplicate */
> > -ÂÂÂ if (!ret)
> > -ÂÂÂÂÂÂÂ ret = -EINVAL;
> > +ÂÂÂ if (!ret) {
> > +ÂÂÂÂÂÂÂ dev_warn(&hdev->pdev->dev, "VF %d mac(%pM) has been existed\n",
>
>  ÂÂ Maybe just "exists"? The grammar is certainly wrong as is. :-)
>
> > +ÂÂÂÂÂÂÂÂÂÂÂÂ vport->vport_id, addr);
> > +ÂÂÂÂÂÂÂ return 0;
> > +ÂÂÂ }
> > ÂÂÂÂÂ dev_err(&hdev->pdev->dev,
> > ÂÂÂÂÂÂÂÂÂ "PF failed to add unicast entry(%pM) in the MAC table\n",
>
> MBR, Sergei

ok, thanks.

> .