Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr

From: Jacek Anaszewski
Date: Tue Apr 02 2019 - 15:05:43 EST


Hi Colin,

Thank you for the patch.

On 3/30/19 9:37 PM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Currently data->i2c_addr is being assigned twice, first with the
value 0x09 and then immediately afterwards with the value 0x08.
The first assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/leds/leds-blinkm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 851c1920b63c..11b771fb933b 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -594,7 +594,6 @@ static int blinkm_probe(struct i2c_client *client,
goto exit;
}
- data->i2c_addr = 0x09;
data->i2c_addr = 0x08;
/* i2c addr - use fake addr of 0x08 initially (real is 0x09) */
data->fw_ver = 0xfe;


Applied.

--
Best regards,
Jacek Anaszewski