Re: [PATCH 7/7] cpufreq: ppc_cbe: fix possible object reference leak

From: Markus Elfring
Date: Tue Apr 02 2019 - 06:43:40 EST


> The call to of_get_cpu_node returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.

I would prefer a wording like the following.

A reference counter was incremented for a CPU node by a call of
the function âof_get_cpu_nodeâ.
Thus decrement it after the last usage.


> Detected by coccinelle with the following warnings:

I wonder about the shown duplicate notification.
Can a single message be sufficient for the code search result
in this source file?

Regards,
Markus