Re: [PATCH 2/2] soc: imx: gpcv2: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 11:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Cheers,
-Mukesh
> ---
>   drivers/soc/imx/gpcv2.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index e06bf12..31b8d00 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -563,7 +563,6 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	struct device_node *pgc_np, *np;
>   	struct regmap *regmap;
> -	struct resource *res;
>   	void __iomem *base;
>   	int ret;
>   
> @@ -573,8 +572,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	res  = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);
>