Re: [PATCH][next] iavf: iavf_client: use struct_size() helper

From: Jeff Kirsher
Date: Fri Mar 29 2019 - 18:37:37 EST


On Thu, 2019-03-28 at 15:36 -0500, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> struct boo entry[];
> };
>
> size = sizeof(struct foo) + count * sizeof(struct boo);
>
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
>
> size = struct_size(instance, entry, count);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/iavf/iavf_client.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Thanks Gustavo, I will queue this up.

Attachment: signature.asc
Description: This is a digitally signed message part