Re: [PATCH] riscv: fix syscall_get_arguments() and syscall_set_arguments()

From: Dmitry V. Levin
Date: Fri Mar 29 2019 - 14:16:25 EST


On Fri, Mar 29, 2019 at 01:15:14PM -0400, Steven Rostedt wrote:
> On Fri, 29 Mar 2019 20:12:21 +0300
> "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> wrote:
>
> > RISC-V syscall arguments are located in orig_a0,a1..a5 fields
> > of struct pt_regs.
> >
> > Due to an off-by-one bug and a bug in pointer arithmetic
> > syscall_get_arguments() was reading s3..s7 fields instead of a1..a5.
> > Likewise, syscall_set_arguments() was writing s3..s7 fields
> > instead of a1..a5.
>
> Should I add this to my series? And then rebase on top of it?

This is fine with me. If you are adding the fix for riscv,
please consider adding the fix for csky, too.


--
ldv

Attachment: signature.asc
Description: PGP signature