Re: [RFC][PATCH 0/4 v2] sycalls: Remove args i and n from syscall_get_arguments()

From: Steven Rostedt
Date: Fri Mar 29 2019 - 13:40:50 EST


On Fri, 29 Mar 2019 10:24:58 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> The whole series looks fine to me.

Great! I may just send a pull request to you, after some fixes (see
below).

>
> I still suspect that we should just remove the syscall_set_arguments()
> thing entirely, but even without that, the cleanup of the calling
> convention is at least an improvement.

I'll keep it around for now, but this should go as a warning to Dmitry,
to get something using it soon, or they may be dropped.

Also, Dmitry found a few bugs with the current
syscall_set/get_arguments() on some of the archs (riscv and csky). Which
I'll add at the front of this series and update my changes to keep the
same logic.

Then I'll post a non RFC version.

-- Steve