Re: [PATCH net-next] can: kvaser_usb: Use struct_size() in alloc_candev()

From: Gustavo A. R. Silva
Date: Thu Mar 28 2019 - 13:58:58 EST


Hi Marc,

On 2/26/19 1:52 AM, Marc Kleine-Budde wrote:
> On 2/8/19 4:10 AM, Gustavo A. R. Silva wrote:
>> One of the more common cases of allocation size calculations is finding
>> the size of a structure that has a zero-sized array at the end, along
>> with memory for some number of elements for that array. For example:
>>
>> struct foo {
>> int stuff;
>> void *entry[];
>> };
>>
>> instance = alloc(sizeof(struct foo) + count * sizeof(void *));
>>
>> Instead of leaving these open-coded and prone to type mistakes, we can
>> now use the new struct_size() helper:
>>
>> instance = alloc(struct_size(instance, entry, count));
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Applied to linux-can-next.
>

I noticed this patch is not in linux-next.

I wonder if you actually applied it to your tree.

Thanks
--
Gustavo