Re: [PATCH 2/6] bitmap_parselist: move non-parser logic to helpers

From: Andrew Morton
Date: Mon Mar 25 2019 - 17:54:39 EST


On Tue, 26 Mar 2019 00:07:44 +0300 Yury Norov <yury.norov@xxxxxxxxx> wrote:

> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -477,6 +477,42 @@ int bitmap_print_to_pagebuf(bool list, char *buf, const unsigned long *maskp,
> }
> EXPORT_SYMBOL(bitmap_print_to_pagebuf);
>
> +/*
> + * Region 9-38:4/10 describes the following bitmap structure:
> + * 0 9 12 18 38
> + * .........****......****......****......
> + * ^ ^ ^ ^
> + * start off grlen end
> + */
> +struct region {
> + unsigned int start;
> + unsigned int off;
> + unsigned int grlen;
> + unsigned int end;
> +};

grlen means... group_len, I think?

Perhaps it should be called group_len ;)