Re: [PATCH] Documentation: acpi: Add an example for PRP0001

From: Andy Shevchenko
Date: Mon Mar 25 2019 - 11:01:49 EST


On Mon, Mar 25, 2019 at 02:42:09PM +0000, Thomas Preston wrote:
> On 25/03/2019 13:04, Andy Shevchenko wrote:
> > On Mon, Mar 25, 2019 at 01:51:18PM +0200, Andy Shevchenko wrote:
> > > On Mon, Mar 25, 2019 at 10:31:13AM +0100, Rafael J. Wysocki wrote:

> > > Though one thing I would like to add (not directly related to the patch
> > > per se), i.e. it would be nice to keep such examples under meta-acpi [1]
> > > umbrella as a database for such excerpts.
> > >
> > > Thomas, can you do that?
> > >
> > > [1]: https://github.com/westeri/meta-acpi
>
> I will :)

Thank you! I will take either GH PR, or you may send an email to maintainers,
i.e. Mika and me (PR is preferable because it would be seen publicly)

> > > > > + Name (_HID, "TITMP75") /* _HID will appear in sysfs */
> >
> > Sorry for not noticing earlier.
> >
> > Is this an official ID for the chip? We discourage people to invent ACPI IDs on
> > their own.

> The device is a TI tmp75b temperature sensor [0]. The HID is completely
> made up, I'm afraid. It doesn't exist in the registry.

Thanks for clarification. In that case I would rather recommend to use simple
PRP0001 as a _HID.

> [0] http://www.ti.com/lit/ds/symlink/tmp75b.pdf

--
With Best Regards,
Andy Shevchenko