Re: [RFC PATCH v2 2/5] dt-bindings: mtd: Add binding documentation for Hyperbus memory devices

From: Vignesh Raghavendra
Date: Mon Mar 25 2019 - 09:10:17 EST


Hi,

On 24/03/19 9:48 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote:
>
>> Add DT binding documentation for Hyperbus memory devices. Only
>> Hyperflash is supported at the moment.
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
>> ---
>> Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt | 6 ++++++
>> 1 file changed, 6 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt b/Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt
>> new file mode 100644
>> index 000000000000..cb408f80b868
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt
>> @@ -0,0 +1,6 @@
>> +Bindings for Hyperflash NOR flash chips compliant with Cypress Hyperbus
>> +specification and supports Cypress CFI specification 1.5 command set.
>> +
>> +Required properties:
>> +- compatible : "cypress,hyperflash" for Hyperflash NOR chips
>
> What about "cfi-flash", shouldn't it be also specified?

Oh, right. I missed that. Hyperflash is CFI compliant.
Will add that next time. Thanks!

>
>> +- reg : Address where flash's memory mapped space
>
> MBR, Sergei
>

--
Regards
Vignesh