Re: [PATCH net] netlink: fix a memory leak on error path

From: cgxu519
Date: Sun Mar 24 2019 - 21:19:25 EST


On 3/22/19 7:03 PM, Kirill Tkhai wrote:
Hi, Chengguang,

On 22.03.2019 13:58, Chengguang Xu wrote:
In genl_register_family(), when idr_alloc() fails,
we forget to free family->attrbuf.

Note, some callers call genl_unregister_family() to clean up
on error path, it doesn't work because the family is inserted
to the global list in the nearly last step.

Fixes: 2ae0f17df1c ("genetlink: use idr to track families").
Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>
have you seen https://patchwork.ozlabs.org/patch/1059834/ ?

Sorry, I didn't notice that because I'm mainly working on linus-tree.
Please just ignore this patch.

Thanks.