RE: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

From: Gary Guo
Date: Sun Mar 24 2019 - 15:14:48 EST




> -----Original Message-----
> From: linux-riscv <linux-riscv-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of Anup
> Patel
> Sent: Sunday, March 24, 2019 11:08
> To: Palmer Dabbelt <palmer@xxxxxxxxxx>; Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Cc: Anup Patel <Anup.Patel@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Mike
> Rapoport <rppt@xxxxxxxxxxxxx>; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Atish
> Patra <Atish.Patra@xxxxxxx>; Paul Walmsley <paul.walmsley@xxxxxxxxxx>;
> linux-riscv@xxxxxxxxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany
>
> diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile
> index eb22ab49b3e0..7307609d405b 100644
> --- a/arch/riscv/mm/Makefile
> +++ b/arch/riscv/mm/Makefile
> @@ -3,3 +3,5 @@ obj-y += fault.o
> obj-y += extable.o
> obj-y += ioremap.o
> obj-y += cacheflush.o
> +
> +CFLAGS_init.o := -mcmodel=medany

I think you should also remove CFLAGS_setup.o from kernel/Makefile, as I think it was there solely for the correctness of setup_vm. As setup_vm is now in mm/init.o, the old CFLAGS probably isn't needed and should be removed in the same patch. Disclaimer: I haven't tested it.