Re: [PATCH -next] selinux: Make selinux_kernfs_init_security static

From: Paul Moore
Date: Fri Mar 22 2019 - 16:02:44 EST


On Fri, Mar 22, 2019 at 1:46 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> On Fri, Mar 22, 2019 at 3:04 PM Yue Haibing <yuehaibing@xxxxxxxxxx> wrote:
> > From: YueHaibing <yuehaibing@xxxxxxxxxx>
> >
> > Fix sparse warning:
> >
> > security/selinux/hooks.c:3389:5: warning:
> > symbol 'selinux_kernfs_init_security' was not declared. Should it be static?
> >
> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Yup, another trivial mistake on my part...
>
> Acked-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
>
> Thanks for catching that!

Yes, thanks for the patch; I don't always check for static (or
const'ified args) as much as I should when reviewing code. Merged
into selinux/next.

--
paul moore
www.paul-moore.com