Re: [PATCH v4] perf tools: Add missing case value

[Solomon Tan]

Hi Liu Yan,

On Friday, March 22, 2019 9:59 AM, Leo Yan <leo.yan@xxxxxxxxxx> wrote:

> Hi Solomon,
> 

> On Fri, Mar 22, 2019 at 12:47:11AM +0000, Solomon Tan wrote:
> 

> [...]
> 

> > > On my side this patch is no different from V3, i.e it doesn't pass checkpatch
> > > and it doesn't apply on my next tree.
> > > Mathieu
> > > 

> > > > 

> > > 

> > > pub RSA 2048/C88289A6 2018-05-09solomonbstoner@xxxxxxxxxxxxx solomonbstoner@xxxxxxxxxxxxx
> > > 

> > > > sub RSA 2048/7C5E8D6D 2018-05-09
> > 

> > I created a new branch from `next` for the patch mentioned above. Should I
> > have made the patch directly on the `next` branch instead?
> > I ran the following 2 commands to test the files I edited:
> > 

> >     perl scripts/checkpatch.pl -f tools/build/feature/test-libopencsd.c
> >     perl scripts/checkpatch.pl -f tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> >     

> > 

> > The commands reported that the files "has no obvious style problems and is ready
> > for submission." For your kind advice please. Thank you.
> 

> Suggest you to use below flow for sending patch:
> 

> -   git format HEAD~1: generate patch
> -   ./scripts/checkpatch.pl xxxx.patch: check patch format
> -   git send-email xxxx.patch: use git to send patch so avoid any
>     unexpected characters in the mail

Thank you for your kind guidance. I realised that Mr Poirier
had trouble with my patch because I copied-and-pasted it
into a GUI web client. I was not aware previously that patch
corruptions can happen that way.

I have amended the patch and tested it with both `checkpatch`
and `git am` before sending it out. 


>     

>     P.s. Marc has a good presentation [1] for upstreaming patches, you
>     could check page 16 for how to use the git tool.
>     

>     [1] https://elinux.org/images/2/26/Getting-Your-Patches-in-Mainline-Linux-What-Not-To-Do-and-a-Few-Things-You-Could-Try-Instead-Marc-Zyngier-ARM.pdf
>     

>     Thanks,
>     Leo Yan
>

Attachment: publickey - solomonbstoner@protonmail.ch - 0xA77658B9.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature