Re: [PATCH 2/2] w1: fix the resume command API

From: Mariusz Bialonczyk
Date: Thu Mar 21 2019 - 06:11:56 EST


Hi Evgeniy,

On Tue, 19 Mar 2019 17:21:09 +0300
Evgeniy Polyakov <zbr@xxxxxxxxxxx> wrote:

> Looks like this may break the search logic, can you check that with this patch applied
> some other single slave device will correctly 'tell' its id and it can be addressed via match rom (like, basically, just reading temperature or something like that)?

Yes, I have tested it in a mixed environment (regarding single slave/multidrop):

/sys/devices/w1_bus_master5 # ll
total 0
drwxr-xr-x 9 root 0 0 Mar 21 10:53 .
drwxr-xr-x 17 root 0 0 Mar 2 16:49 ..
drwxr-xr-x 4 root 0 0 Mar 21 10:55 28-00000921ff5e
drwxr-xr-x 3 root 0 0 Mar 21 11:04 29-0000001246a4
drwxr-xr-x 3 root 0 0 Mar 21 11:04 29-0000001246b1
drwxr-xr-x 3 root 0 0 Mar 21 11:04 29-0000001246b9
drwxr-xr-x 3 root 0 0 Mar 21 10:54 29-0000001246bc
drwxr-xr-x 3 root 0 0 Mar 21 10:53 3a-0000000f354f

/sys/devices/w1_bus_master6 # ll
total 0
drwxr-xr-x 4 root 0 0 Mar 21 10:54 .
drwxr-xr-x 17 root 0 0 Mar 2 16:49 ..
drwxr-xr-x 3 root 0 0 Mar 21 11:07 29-0000001246a9

No problem with searching and using other slaves on the bus.

regards,
--
Mariusz BiaÅoÅczyk | xmpp/e-mail: manio@xxxxxxxxxx
https://skyboo.net | https://github.com/manio