RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static

From: Jiang, Dave
Date: Wed Mar 20 2019 - 11:20:47 EST




> -----Original Message-----
> From: Yue Haibing [mailto:yuehaibing@xxxxxxxxxx]
> Sent: Wednesday, March 20, 2019 7:08 AM
> To: Jiang, Dave <dave.jiang@xxxxxxxxx>; jdmason@xxxxxxxx;
> allenbh@xxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-ntb@xxxxxxxxxxxxxxxx; YueHaibing
> <yuehaibing@xxxxxxxxxx>
> Subject: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
>
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Fix sparse warning:
>
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
> symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?

For now yes. Thanks!

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev
> *ntb, int pidx, int idx,
> return 0;
> }
>
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> - resource_size_t *db_size,
> - u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t
> *db_addr,
> + resource_size_t *db_size,
> + u64 *db_data, int db_bit)
> {
> phys_addr_t db_addr_base;
> struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>