Re: [PATCH v6 1/7] psi: introduce state_mask to represent stalled psi states

From: Stephen Rothwell
Date: Tue Mar 19 2019 - 20:02:59 EST


Hi Suren,

On Tue, 19 Mar 2019 16:56:13 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> The psi monitoring patches will need to determine the same states as
> record_times(). To avoid calculating them twice, maintain a state mask
> that can be consulted cheaply. Do this in a separate patch to keep the
> churn in the main feature patch at a minimum.
>
> This adds 4-byte state_mask member into psi_group_cpu struct which results
> in its first cacheline-aligned part becoming 52 bytes long. Add explicit
> values to enumeration element counters that affect psi_group_cpu struct
> size.
>
> Link: http://lkml.kernel.org/r/20190124211518.244221-4-surenb@xxxxxxxxxx
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Dennis Zhou <dennis@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: Li Zefan <lizefan@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

This last SOB line should not be here ... it is only there on the
original patch because I import Andrew's quilt series into linux-next.

--
Cheers,
Stephen Rothwell

Attachment: pgpIJsKX7RMIJ.pgp
Description: OpenPGP digital signature