Re: [PATCH] peak_usb: fix clang build warning

From: David Miller
Date: Thu Mar 07 2019 - 12:40:16 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Thu, 7 Mar 2019 11:31:55 +0100

> Clang points out undefined behavior when building the pcan_usb_pro driver:
>
> drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
>
> Changing the function prototype to avoid argument promotion in the
> varargs call avoids the warning, and should make this well-defined.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied.