Re: [PATCH] davinci_emac: always build in CONFIG_OF code

From: David Miller
Date: Thu Mar 07 2019 - 12:29:39 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Thu, 7 Mar 2019 10:31:20 +0100

> clang warns about what seems to be an unintended use of an obscure C
> language feature where a forward declaration of an array remains usable
> when the final definition is never seen:
>
> drivers/net/ethernet/ti/davinci_emac.c:1694:34: error: tentative array definition assumed to have one element [-Werror]
> static const struct of_device_id davinci_emac_of_match[];
>
> There is no harm in always enabling the device tree matching code here,
> and it makes the code behave in a more conventional way aside from
> avoiding the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied.